Fix #5455: Fix computation of companion object of opaque type #5480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was wondering why this passed the tests before. It turns out that by accident we always had an operand of type |
i5455.scala showed another misuse: One could get at the local copy of an opaque type even though this type was not defined. This commit closes that loophole. Aside: It might be better to do the opaque type expansion in Namer instead of in Desugar. This could let us use a synthetic name for the local alias and thereby avoid namespace pollution. Right now one cannot define a type with the same name as the opaque type alias in the latter's companion object. It's a crazy thing to do, but still...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.